Skip to content

chore: Fix builds #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 29, 2025
Merged

chore: Fix builds #5

merged 18 commits into from
Apr 29, 2025

Conversation

@kevinmichaelchen
Copy link
Owner

@kevinmichaelchen kevinmichaelchen commented Apr 29, 2025 •
edited
Loading

https://napi.rs/docs/introduction/getting-started

  • it's a best practice with NAPI to not put all your binaries (.node files) in the same NPM package
  • instead, we publish a package per binary
  • for testing (locally and in CI), we copy the .node file into the same directory as src/index.cjs (the napi loader)
  • for external consumers, they'll need to npm install the appropriate npm package

@kevinmichaelchen kevinmichaelchen changed the title attempt 2 chore: Fix builds Apr 29, 2025
@kevinmichaelchen kevinmichaelchen merged commit 59344cb into main Apr 29, 2025
11 checks passed
@kevinmichaelchen kevinmichaelchen deleted the fix-cjs-invocation branch April 29, 2025 23:55
@kevinmichaelchen kevinmichaelchen mentioned this pull request Apr 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinmichaelchen